Make psvDebugScreen usable from prx #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yne
force-pushed
the
patch-1
branch
2 times, most recently
from
9aac54d
to
60dbada
Compare
|
Maybe put prx version under a ifdef? |
|
@frangarcj Yeah, the first version used #ifdef but then a realized that this version also solve the "EBOOT loading EBOOT" issue. So I removed the #define because it will simply work for any cases. |
yne
force-pushed
the
patch-1
branch
2 times, most recently
from
bf1d4bf
to
90b0a3b
Compare
Using psvDebugScreen from a prx lead to the following issues: - vsnprintf call crash the app and so, shall be directed to the sceClib version - possible multiple call to psvDebugScreenInit (from eboot and prx) that could lead to a FrameBuffer stealing - modulo operation are not available when prx compiled with -nostdlib This commit aim to resolve those issues, but also give an explanation using comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using psvDebugScreen from a prx lead to the following issues:
This commit aim to resolve those issues, but also give an explanation in comment.