Do not link SDL2_mixer to libxmp, because LGPL #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkwouter
force-pushed
the
no-lgpl-for-sdl2-mixer
branch
from
cb3e12e
to
36fd814
Compare
|
#279 (comment) mpg123 is also problematic for sdl2_mixer |
d3m3vilurr
reviewed
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed it to libxmp-lite now, which is MIT licensed instead of LGPL. Building SDL2_mixer with libxmp-lite was kinda broken, so I had to patch it. I've tested it and SDL2_mixer still seems to work like expected