Update index.js and test.js to add pronunciation support #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates index.js to add support for pronunciation (say, for Pinyin in Chinese)
Updates test.js to add in a test case for the pronunciation support.
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 92.42% 92.64% +0.22%
==========================================
Files 2 2
Lines 66 68 +2
==========================================
+ Hits 61 63 +2
Misses 5 5
Continue to review full report at Codecov.
|
rawr51919
changed the title
vitalets
requested changes
Apr 1, 2019
Update index.js as per vitalets' suggestion
Owner
|
👍 |
Author
|
Ye. That'd be a good idea. EDIT: Done. |
Update the readme as per vitalets' suggestion
vitalets
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates index.js to add support for pronunciation (say, for Pinyin in Chinese) (carryover from unmaintained upstream PR matheuss#61).