Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tiles): 3DTile services #2635

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(tiles): 3DTile services #2635

wants to merge 4 commits into from

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Sep 8, 2023

@igorDykhta jamming on your code from the attribution PR...


/**
* @see https://developers.google.com/maps/documentation/tile/policies
* attribution shouldn't be hidden (right now dataset attribution is only partly shown and expanded on hover).
Copy link
Collaborator

@igorDykhta igorDykhta Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are Studio-related comments.

modules/tiles/src/tile3d-service/tile3d-service.ts Outdated Show resolved Hide resolved

/** Queries metadata from a 3D tileset service.
* @param url Url of a 3D tileset.
* @param this.accessToken Optional access token.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params are for the constructor above

title: 'Built with Google Maps.',
url: '',
logoUrl:
'https://developers.google.com/static/maps/documentation/images/google_on_non_white.png',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Google we we need to place the attribution logo on our CDN.

modules/tiles/src/tile3d-service/tile3d-service.ts Outdated Show resolved Hide resolved
modules/tiles/src/tile3d-service/tile3d-service.ts Outdated Show resolved Hide resolved
const assetId = matched && matched[1];
return assetId ? {assetId, resource: 'tileset.json'} : null;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need getLoadOptions here?
loadOptions: {'cesium-ion': {accessToken, worker: true}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants