DataFilterExtension category filtering uint32 attribute #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ibgreen
approved these changes
Jan 14, 2025
| @@ -115,6 +115,12 @@ const defaultOptions: Required<DataFilterExtensionOptions> = { | |||
| countItems: false | |||
| }; | |||
|
|
|||
| const CATEGORY_TYPE_FROM_SIZE = { | |||
| 1: 'uint' as const, | |||
There was a problem hiding this comment.
This will need another pass for WebGPU some day...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9153
Background
The type of the
filterCategoryValuesis currently float, so even though we store the bitmask in aUint32Array, the GPU gets the values as floating point, which will lead to precision issues depending on the platform. By using unsigned integers we should get better accuracyChange List
uint32