Python 3 compatability #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates to include compatability with py3, whilst retaining all functionality in py2. The evernote library is not yet py3 compatible, so is not used in the py3 version. It is however still retained when using py2.
|
(I am not a core contributor) This looks like a good PR, but has a lot of unrelated changes along with the functional ones. It would be easier to review if these were separate. both |
|
This PR is from quite a while ago now, the maintainer seems to have abandoned this project sadly. I did continue work on this on my own fork but don't have much time for it now either. |
|
The evernote dependency is not allowing installation for python3 is there anyway to ignore the dependency because I don't need its functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated to PR #69, with commits squashed to present a cleaner history. It still addresses issue #36.
This updates to include compatibility with py3, whilst retaining
all functionality in py2.
The evernote library is not yet py3 compatible, so is not used in
the py3 version. It is however still retained when using py2.
Also fabric isn't compatible with py3 yet either. I haven't worked with it before, so am not sure how important it is to the dev workflow here. For now I've changed tests to run directly instead of via the fabric generated runtests.py.