(AdtPlugin) fixes and regression tests for #581 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for investigating the issue. I assume the PR is WIP until a complete solution is found. If so, please mark the PR as such, so that it doesn't get merged accidentally, or code-reviewed prematurely. |
|
I just converted this PR to draft. Although the work-around in this PR works, I suspect a better solution will come out of #581. It seems to be related to a problem in the transformer logic itself and the final fix is probably better addressed in that part of the code (hoping someone might look alongside to see what the issue is in the transformer, I didn't have much luck spotting it yet :) ). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ADT plugin did not handle
resultexpressions in post-conditions yet properly. This PR is a patch to fix a couple of corner cases with additional regression tests.