Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds functions as a dependency to methods #549

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds functions as a dependency to methods #549

wants to merge 2 commits into from

Conversation

ArquintL
Copy link
Member

Similarly to domain axioms, methods depend on functions even when there is no explicit call to them.

Fixes #548

mschwerhoff
mschwerhoff reviewed Dec 17, 2021
View reviewed changes
Copy link
Contributor

@mschwerhoff mschwerhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply adding all functions seems OK, but I find it incoherent that we are more fine-grained when it comes to methods and predicates.

I believe Marco wrote a more fine-grained dependency analysis once. Did you already ask him?

mschwerhoff
mschwerhoff approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@mschwerhoff mschwerhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coarse-grained, but otherwise OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwerhoff mschwerhoff mschwerhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function modifications are not considered for caching
2 participants
@ArquintL @mschwerhoff