QueryFrontend: pre-compile regexp (thanos-io#5383)

* pre compile regexp Signed-off-by: Jin Dong <[email protected]> * rename oppattern to labelvaluespattern Signed-off-by: Jin Dong <[email protected]>
vinted · May 25, 2022 · 7898fb2 · 7898fb2
1 parent 6c07dd9
commit 7898fb2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/queryfrontend/roundtrip.go b/pkg/queryfrontend/roundtrip.go
@@ -27,6 +27,8 @@ const (
 	seriesOp       = "series"
 )
 
+var labelValuesPattern = regexp.MustCompile("/api/v1/label/.+/values$")
+
 // NewTripperware returns a Tripperware which sends requests to different sub tripperwares based on the query type.
 func NewTripperware(config Config, reg prometheus.Registerer, logger log.Logger) (queryrange.Tripperware, error) {
 	var (
@@ -120,8 +122,7 @@ func getOperation(r *http.Request) string {
 		case strings.HasSuffix(r.URL.Path, "/api/v1/series"):
 			return seriesOp
 		default:
-			matched, err := regexp.MatchString("/api/v1/label/.+/values$", r.URL.Path)
-			if err == nil && matched {
+			if labelValuesPattern.MatchString(r.URL.Path) {
 				return labelValuesOp
 			}
 		}