Merge pull request #119 from vinted/0370_locking_fix

receive/multitsdb: defer unlock properly (thanos-io#7857)
vinted · Oct 24, 2024 · 7035d86 · 7035d86
2 parents 44d4890 + b602a5d
commit 7035d86
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/receive/multitsdb.go b/pkg/receive/multitsdb.go
@@ -587,10 +587,10 @@ func (t *MultiTSDB) TSDBLocalClients() []store.Client {
 
 	t.mtx.RUnlock()
 	t.mtx.Lock()
+	defer t.mtx.Unlock()
 	if !t.tsdbClientsNeedUpdate {
 		return t.tsdbClients
 	}
-	defer t.mtx.Unlock()
 
 	res := make([]store.Client, 0, len(t.tenants))
 	for _, tenant := range t.tenants {