store: use noop pool

Simply not returning slices leads to exhausted pool errors. Use noop pool instead that returns slices directly. Signed-off-by: Giedrius Statkevičius <[email protected]>
vinted · Dec 4, 2024 · 0c08c63 · 0c08c63
1 parent b442da7
commit 0c08c63
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/cmd/thanos/store.go b/cmd/thanos/store.go
@@ -40,6 +40,7 @@ import (
 	"github.com/thanos-io/thanos/pkg/info/infopb"
 	"github.com/thanos-io/thanos/pkg/logging"
 	"github.com/thanos-io/thanos/pkg/model"
+	"github.com/thanos-io/thanos/pkg/pool"
 	"github.com/thanos-io/thanos/pkg/prober"
 	"github.com/thanos-io/thanos/pkg/runutil"
 	grpcserver "github.com/thanos-io/thanos/pkg/server/grpc"
@@ -388,10 +389,7 @@ func runStore(
 
 	queriesGate := gate.New(extprom.WrapRegistererWithPrefix("thanos_bucket_store_series_", reg), int(conf.maxConcurrency), gate.Queries)
 
-	chunkPool, err := store.NewDefaultChunkBytesPool(uint64(conf.chunkPoolSize))
-	if err != nil {
-		return errors.Wrap(err, "create chunk pool")
-	}
+	chunkPool := pool.NoopPool[byte]{}
 
 	options := []store.BucketStoreOption{
 		store.WithLogger(logger),

diff --git a/pkg/store/bucket.go b/pkg/store/bucket.go
@@ -3515,9 +3515,9 @@ func (r *bucketChunkReader) Close() error {
 	}
 	r.block.pendingReaders.Done()
 
-	//for _, b := range r.chunkBytes {
-	//	r.block.chunkPool.Put(b)
-	//}
+	for _, b := range r.chunkBytes {
+		r.block.chunkPool.Put(b)
+	}
 	return nil
 }