Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DLQ reporting #16

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Change DLQ reporting #16

merged 1 commit into from
Oct 24, 2023

Conversation

buinauskas
Copy link
Collaborator

@buinauskas buinauskas commented Oct 24, 2023 •
edited
Loading

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose of PR

Currently, if document indexing fails due to a server or proxy error, we will log that record to the dead letter queue. This is not ideal, a dead letter queue should only log poisonous messages.

Testing

  • Did you add testing to account for any new or changed work?

N/A

Review notes

Issues Closed or Referenced

  • Closes # (this will automatically close the issue when the PR closes)
  • References # (this references the issue but does not close with PR)

@buinauskas buinauskas force-pushed the feat/dlq_only_malformed branch from 6bfbc79 to 5da8031 Compare October 24, 2023 13:16
@buinauskas buinauskas merged commit 8d35955 into master Oct 24, 2023
2 checks passed
@buinauskas buinauskas deleted the feat/dlq_only_malformed branch October 24, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakimcikas Jakimcikas Jakimcikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buinauskas @Jakimcikas