Simpler Webpack 5 config #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjsj
commented
Nov 28, 2023
.pre-commit-config.yaml
Outdated
| args: [--fix] | ||
| # Run the formatter. | ||
| - id: ruff-format | ||
| - repo: https://github.com/pre-commit/mirrors-eslint |
fjsj
commented
Nov 28, 2023
| ], | ||
| "@babel/preset-react" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Using this now instead of babel.config.js. Also, order matters here!
fjsj
commented
Nov 28, 2023
| @@ -6,81 +6,77 @@ | |||
| "engines": { | |||
| "node": ">=18 <21" | |||
| }, | |||
| "main": "index.js", | |||
| "prettier": "eslint-config-vinta/prettier", | |||
| "browserslist": "> 0.25%, not dead", | |||
There was a problem hiding this comment.
I guess we didn't use that before and were generating larger bundles unnecessarily.
fjsj
commented
Nov 28, 2023
fjsj
commented
Nov 28, 2023
| "scripts": { | ||
| "test": "jest", | ||
| "test:watch": "npm test -- --watch", | ||
| "test:update": "npm test -- --u", | ||
| "start": "babel-node server.js", | ||
| "build": "NODE_ENV=production webpack --progress --config webpack.prod.config.js --bail", | ||
| "start": "webpack serve --mode=development --hot", |
There was a problem hiding this comment.
Avoid the custom server.js file.
fjsj
commented
Nov 28, 2023
| "start": "babel-node server.js", | ||
| "build": "NODE_ENV=production webpack --progress --config webpack.prod.config.js --bail", | ||
| "start": "webpack serve --mode=development --hot", | ||
| "build": "NODE_ENV=production webpack --progress --bail --mode=production", | ||
| "lint": "eslint frontend --fix", | ||
| "coverage": "jest --coverage" | ||
| }, | ||
| "dependencies": { |
fjsj
commented
Nov 28, 2023
| @@ -0,0 +1,113 @@ | |||
| const path = require("path"); | |||
There was a problem hiding this comment.
Please review this whole file. I simplified it greatly.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge first #636