Removes as_chain #167
Merged
Removes as_chain #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjsj
reviewed
Sep 11, 2024
| @@ -464,15 +388,23 @@ def as_graph(self, thread_id: Any | None = None) -> Runnable[dict, dict]: | |||
| Returns: | |||
| the compiled graph | |||
| """ | |||
| # DjangoChatMessageHistory must be here because Django may not be loaded yet elsewhere. | |||
| # DjangoChatMessageHistory was used in the context of langchain, now that we are using | |||
| # langgraph this can be further simplified by just porting the add_messages logic. | |||
There was a problem hiding this comment.
Is this tracked? So we don't need the DjangoChatMessageHistory wrapper anymore?
There was a problem hiding this comment.
Yes, it seems like it could be replaced by one simple method that retrieves the message history and another that adds new ones. I created an issue for this #169
fjsj
reviewed
Sep 11, 2024
fjsj
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_chainmethodchainin docs