Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rust port #3

Closed
wants to merge 6 commits into from
Closed

Conversation

kylebarron
Copy link
Collaborator

@kylebarron kylebarron commented Jul 18, 2023

for #2

This compiles but I probably made a mistake in porting the color scale conversion functions and so it's giving incorrect values as output.
image

I can't seem to install the cython version, so I didn't take time to try and track down where the incorrect change was

You can test this with

cd rust
virtualenv env
source ./env/bin/activate
pip install maturin
maturin develop

(you need Rust installed) then

from color_operations import saturate_rgb

@kylebarron
Copy link
Collaborator Author

We added one test for RGB color saturation (from rio-color) and it's working! So it turns out that the code very likely did originally work, but that setting a satmult of 50 was too high and it saturated the colors all the way to 0, 1, 1

@kylebarron
Copy link
Collaborator Author

Closing in favor of #8

@kylebarron kylebarron closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant