Update vimeo.php #11
Open
Update vimeo.php #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the extra expl, to VimeoAPIException, the standard message is to vauge to know what is the real issue unless digging into the code. Ex: With just the VimeAPIExpection -> results are Fatal error: Uncaught exception 'VimeoAPIException' with message 'Invalid / expired token VimeoAPIException: Invalid / expired token in --the two messages are the same with no real explanation If you add the new Exception(expl), the results are: Fatal error: Uncaught exception 'Exception' with message 'The oauth_timestamp passed is either too far in the past or in the future. VimeoAPIException: Invalid / expired token --this new message at least narrows the issue with the server internal clock being incorrect.
|
Looks great, our CLA system should be live soon and I'll update you when we can merge it all in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the extra expl, to VimeoAPIException, the standard message is to vauge to know what is the real issue unless digging into the code.
Ex:
With just the VimeAPIExpection -> results are
Fatal error: Uncaught exception 'VimeoAPIException' with message 'Invalid / expired token
VimeoAPIException: Invalid / expired token in
--the two messages are the same with no real explanation
If you add the new Exception(expl), the results are:
Fatal error: Uncaught exception 'Exception' with message 'The oauth_timestamp passed is either too far in the past or in the future.
VimeoAPIException: Invalid / expired token
--this new message at least narrows the issue with the server internal clock being incorrect.