Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive ImpureVariable issue #10990

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from

Conversation

ghostwriter
Copy link

This patch resolves #10974, via the following changes:

ghostwriter and others added 2 commits May 24, 2024 10:46
Co-Authored-By: Vincent Langlet <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
@VincentLanglet
Copy link
Contributor

Any idea why you get Could not find a usable config.yml, you may have revoked the CircleCI OAuth app. error @ghostwriter ? Is it fixed with some rebase ?

@orklah @weirdan Any time to review this bugfix ? Thanks a lot ! :)

@ghostwriter
Copy link
Author

Any idea why you get Could not find a usable config.yml, you may have revoked the CircleCI OAuth app. error @ghostwriter ? Is it fixed with some rebase ?

No rebase is needed. The maintainers just need to approve the GitHub Actions workflows for this pull request. (GitHub security feature.)

"5 workflows awaiting approval"

@VincentLanglet
Copy link
Contributor

There is this error

**CircleCI Pipeline ** — Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.

@ghostwriter
Copy link
Author

There is this error

**CircleCI Pipeline ** — Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.

Correct, because the workflows are not approved to be triggered by my pull request. (GitHub is not generating the GITHUB_TOKEN for CircleCI)

When a user pushes a commit, opens a PR, or triggers a new CircleCI build via the API or via the UI, CircleCI fetches the configuration file (config.yml) to generate the pipeline. CircleCI will use the author's authentication token (Automatically generated by GitHub per PR) to fetch the config.yml file. When this authentication fails because the token has become invalid or has expired, the user will see the above error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FalsePositive ImpureVariable in constructor
2 participants