Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8.4 #10928

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from
Open

Add support for PHP 8.4 #10928

wants to merge 3 commits into from
+64 −52

Conversation

GromNaN
Copy link
Contributor

@GromNaN GromNaN commented Apr 29, 2024 •
edited
Loading

@GromNaN GromNaN force-pushed the php84 branch 7 times, most recently from 6c0daee to f178309 Compare April 29, 2024 19:05
GromNaN
GromNaN commented Apr 29, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@MidnightDesign
Copy link
Contributor

Composer have some unresolved issues that requires to hide deprecation messages from the output

What does that mean?

@MidnightDesign MidnightDesign mentioned this pull request Sep 3, 2024
Open
@davisenra davisenra mentioned this pull request Sep 10, 2024
Closed
@frederikbosch frederikbosch mentioned this pull request Sep 12, 2024
Open
@ruudk
Copy link
Contributor

ruudk commented Sep 18, 2024

What's needed to move this PR forward? Is there anything I can do to help?

@MidnightDesign
Copy link
Contributor

Thanks for putting your time into this @GromNaN

hafezdivandari
hafezdivandari suggested changes Sep 25, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@davidbyoung davidbyoung mentioned this pull request Sep 29, 2024
Open
@asgrim asgrim mentioned this pull request Sep 30, 2024
Merged
@nishant04412 nishant04412 mentioned this pull request Oct 1, 2024
Open
@nishant04412
Copy link

nishant04412 commented Oct 3, 2024 •
edited
Loading

Can we get this PR merged please or anything still pending ?

@nishant04412 nishant04412 mentioned this pull request Oct 3, 2024
Open
@GromNaN
Add support for PHP 8.4
06ae404 
Calling new ReflectionMethod with a single argument is deprecated
@GromNaN GromNaN marked this pull request as ready for review October 3, 2024 13:45
@GromNaN
E_STRICT deprecated in PHP 8.4
f1e9ba2 
JIT on AArch64 doesn't support opcache.jit_buffer_size above 128M
@GromNaN GromNaN mentioned this pull request Oct 9, 2024
Open
3 tasks
@GromNaN
Copy link
Contributor Author

GromNaN commented Oct 9, 2024 •
edited
Loading

If anyone wants to look at the failing tests. I don't find how they are related to the changes in that PR. They are run on PHP 8.0.30. I cant reproduce in a Docker container with this PHP version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hafezdivandari hafezdivandari hafezdivandari requested changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GromNaN @MidnightDesign @ruudk @nishant04412 @szepeviktor @hafezdivandari