no error for printf with only 1 arg

Fix #9987
vimeo · Jul 3, 2023 · 8d8adef · 8d8adef
1 parent 768b813
commit 8d8adef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php
@@ -70,9 +70,9 @@ public static function getFunctionReturnType(FunctionReturnTypeProviderEvent $ev
             return null;
         }
 
-        // it makes no sense to use sprintf/printf when there is only 1 arg (the format)
+        // it makes no sense to use sprintf when there is only 1 arg (the format)
         // as it wouldn't have any placeholders
-        if (count($call_args) === 1) {
+        if (count($call_args) === 1 && $event->getFunctionId() === 'sprintf') {
             IssueBuffer::maybeAdd(
                 new TooFewArguments(
                     'Too few arguments for ' . $event->getFunctionId() . ', expecting at least 2 arguments',

diff --git a/tests/ReturnTypeProvider/SprintfTest.php b/tests/ReturnTypeProvider/SprintfTest.php
@@ -275,12 +275,6 @@ public function providerInvalidCodeParse(): iterable
                 ',
                 'error_message' => 'InvalidArgument',
             ],
-            'printfOnlyFormat' => [
-                'code' => '<?php
-                    printf("hello");
-                ',
-                'error_message' => 'TooFewArguments',
-            ],
             'printfTooFewArguments' => [
                 'code' => '<?php
                     printf("%s hello %d", "a");