Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with latest addon blueprint and use decorator-transforms #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Mar 26, 2024

v2 addon blueprint: https://github.com/embroider-build/addon-blueprint

Minor gain: using decorator-transforms reduced bundle size for the app.

@SergeAstapov
Copy link
Contributor Author

side note: funnily enough, v5 scenarios pass only because repo uses yarn and yarn incorrectly handles peer dependencies

Copy link
Owner

@villander villander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple requested changes!

@SergeAstapov could you please describe what's size do you mean about the app? Are you talking about the testing-app?

.github/workflows/ci.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
@SergeAstapov SergeAstapov changed the title Sync with embroider-addon blueprint and use decorator-transforms Sync with latest addon blueprint and use decorator-transforms Mar 27, 2024
@SergeAstapov
Copy link
Contributor Author

Couple requested changes!

@SergeAstapov could you please describe what's size do you mean about the app? Are you talking about the testing-app?

added link to PR description.

RE: decorator-transforms/
You may read about this package in https://github.com/ef4/decorator-transforms/
now it comes from v2 addon blueprint, see https://github.com/embroider-build/addon-blueprint/blob/main/files/__addonLocation__/package.json#L37

TL;DR @babel/plugin-proposal-decorators has large footprint in terms of compiled code size. In our app we saw 18% reduction in size for vendor.js and app.js once we introduced decorator-transforms/ and disabled @babel/plugin-proposal-decorators.

@villander
Copy link
Owner

We can merge this PR when CI get green again

@SergeAstapov SergeAstapov force-pushed the sync-blueprint branch 2 times, most recently from bc1c682 to 7731f14 Compare July 10, 2024 02:20
@SergeAstapov
Copy link
Contributor Author

@villander this is refreshed with the latest blueprint as of now and CI is passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants