Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add type hints to _prepare_printer_program and SimpleFunction #204

Merged

Conversation

vil02
Copy link
Owner

@vil02 vil02 commented Dec 5, 2023

Related to #201.

Found 526 errors in 45 files (checked 52 source files)

reduced to

Found 523 errors in 45 files (checked 52 source files)

Copy link

gitpod-io bot commented Dec 5, 2023

@vil02 vil02 force-pushed the add_type_hints_to_prepare_printer_prog_and_SimpleFunction branch from b51738d to 4bc67fd Compare December 5, 2023 19:30
Copy link

codacy-production bot commented Dec 5, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (add2791) 493 493 100.00%
Head commit (64da6b0) 492 (-1) 492 (-1) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#204) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (add2791) 100.00% compared to head (64da6b0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          493       492    -1     
  Branches        43        43           
=========================================
- Hits           493       492    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@vil02 vil02 merged commit 366bb7b into master Dec 6, 2023
18 checks passed
@vil02 vil02 deleted the add_type_hints_to_prepare_printer_prog_and_SimpleFunction branch December 6, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant