Morgan Martin's Project Danebook #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </a> | ||
| <!--company brand link --> | ||
| <%= link_to new_user_path, class: 'navbar-brand col-xs-12', id: 'brand-link' do %> | ||
| <p class="col-xs-4 vertical-align" id="brand-text">Danebook</p> |
There was a problem hiding this comment.
When I'm signed in and click this, it takes me back to the home page, and then when I click on the user's name I get a 404.
|
|
||
| <%= form_for @user do |user_fields| %> | ||
| <div class="row"> | ||
| <%= user_fields.fields_for :profile_attributes do |profile_fields| %> |
There was a problem hiding this comment.
was able to sign up without a first or last name
|
Visually, it looks great. The only issues I found were some routes that didn't lead anywhere. Sometimes the about page went to a 404 and the users index and edit pages led to blank pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.