Code refactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
viepovsky
commented
Dec 18, 2023
•
viepovsky
commented
- change class name PeselNumbers to PeselDigits
- remove validation from PeselDigits constructor to validate and set digits in Pesel constructor
- javadoc changes
- readme.md update
- PeselDigits is now abstract class, PeselDecoder is final class
- change class name PeselNumbers to PeselDigits - remove validation from PeselDigits constructor to validate and set digits in Pesel constructor - javadoc changes - readme.md update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
============================================
+ Coverage 98.43% 98.47% +0.03%
- Complexity 80 84 +4
============================================
Files 7 7
Lines 192 197 +5
Branches 18 18
============================================
+ Hits 189 194 +5
Misses 1 1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.