fix: Safari playback stall with overrideNative and experimentalUseMMS#1601
Open
Demenus wants to merge 1 commit intovideojs:mainfrom
Open
fix: Safari playback stall with overrideNative and experimentalUseMMS#1601Demenus wants to merge 1 commit intovideojs:mainfrom
Demenus wants to merge 1 commit intovideojs:mainfrom
Conversation
mister-ben
reviewed
Mar 12, 2026
src/playlist-controller.js
Outdated
Comment on lines
+259
to
+260
| options.overrideNative && | ||
| options.experimentalUseMMS && |
Contributor
There was a problem hiding this comment.
Suggested change
| options.overrideNative && | |
| options.experimentalUseMMS && |
I think these can be removed. If this code is reached, it's not native playback. And without the MMS check this seems to fix videojs/video.js#9117 too.
Author
There was a problem hiding this comment.
You are right — at that point in the code we are no longer using native playback.
I have removed those flags from the condition.
Thank you for the fast review 👍🏻
Safari playback does not start when using overrideNative together with experimentalUseMMS. This appears to be caused by setting the segment metadata track mode to 'hidden', which can stall playback in Safari when using Managed Media Source. Disable the metadata track in this specific scenario to prevent Safari from processing it and allow playback to start normally. Fixes videojs#1600
Demenus
force-pushed
the
fix/Safari-stall-with-overrideNative-experimentalUseMMS
branch
from
c1d2960 to
84a44ef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
=======================================
Coverage 84.00% 84.01%
=======================================
Files 44 44
Lines 11713 11716 +3
Branches 2625 2627 +2
=======================================
+ Hits 9840 9843 +3
Misses 1873 1873 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Safari playback does not start when using overrideNative together with experimentalUseMMS.
This appears to be caused by setting the segment metadata track mode to hidden, which can stall playback in Safari when using Managed Media Source.
Disabling the metadata track in this specific scenario prevents Safari from processing it and allows playback to start normally.
Fixes #1600
This behavior seems specific to Safari when using MMS. Other browsers (Chrome, Firefox) do not appear to be affected by this issue.
Specific Changes proposed
overrideNative+experimentalUseMMSsegmentMetadataTrack_.mode = 'disabled'instead ofhiddenin this specific scenariohidden) for all other browsers and configurationsRequirements Checklist