Skip to content
This repository has been archived by the owner on Oct 8, 2023. It is now read-only.

Update started.md for import JsonResponse #152

Closed
wants to merge 1 commit into from

Conversation

stantonxu
Copy link

The import JsonResponse problem is not fixed in master branch, therefore this PR.

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.

  2. Run the build.py and test.py scripts.

  3. If you are fixing something, add tests that fail in the current version and pass in yours.

  4. If you're developing a new feature open an issue first to discuss it. Some features may be useful to you but harmful to others be it because of performance, new dependencies or different perspectives.

  5. One more time: Don't forget to add tests.

  6. Ensure the entire test suite is passing and overall performance is not degraded.

The `import JsonResponse` problem is not fixed in master branch, therefore this PR.
@danieldaeschle
Copy link
Contributor

It is fixed, look into __init__.

@stantonxu
Copy link
Author

stantonxu commented Jul 16, 2018

@danieldaeschle which __init__.py you mean? I am looking at the docs at https://docs.vibora.io/, the problem is still there.

@danieldaeschle
Copy link
Contributor

danieldaeschle commented Jul 16, 2018

from vibora import JsonResponse works because vibora/__init__.py imports from .responses import *

@danieldaeschle
Copy link
Contributor

Aaaand this is duplicate with #95

@stantonxu
Copy link
Author

Thanks.

So the package on pypi.org need to be updated, or why don't we just update the docs so that it can work with current package on 'pypi.org'?

@danieldaeschle
Copy link
Contributor

danieldaeschle commented Jul 16, 2018

I don't know why he doesn't up update pypi. Pypi is on version 0.0.6.
This library is on very alpha state and i think he waits to release a more stable version of it. We all working hard on fixing bugs.

Can you close this please?

@stantonxu
Copy link
Author

Close per discuss with @danieldaeschle

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants