Repository navigation
Conversation
denizzzka
changed the title
A CONNECT request carries an authority-form target (host:port), not a URL, so URL.parse() rejects a numeric host with 400 before the handler runs. Skip the eager parse for CONNECT; requestURI keeps the raw authority and the URL-derived fields stay empty.
denizzzka
force-pushed
the
connect-authority-form
branch
from
October 20, 2026 09:18
3e00857 to
19c306d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CONNECT request carries an authority (
host:port), not a URL.Server parses every request target with
URL.parsebefore the handler runs, soCONNECT 1.1.1.1:443gets a 400 (Schema must start with an alphabetical char, found: 1) and the handler never sees it. Hostnames survive by accident: they happen to parse as a scheme.