Integrate experimental HTTP/2 support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
prepare_http2
branch
2 times, most recently
from
29a1b34 to
f36ff1c
Compare
s-ludwig
changed the title
l-kramer
approved these changes
Jun 29, 2024
Based on commit 317ce56 Note that HTTP2ServerExchange is missing the implementation of several methods at this point and nothing is tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates the HTTP/2 additions implemented by @GallaFrancesco into the master branch. This integration uses a new
HTTPServerExchangeinterface to abstract away the protocol differences between HTTP/1.x and HTTP/2, but leaves the rest of the code base untouched to minimize the chances for regressions.Other changes that are in the
http_2_originalbranch will be revisited later.Also note that HTTP/2 support, due to the incomplete and only superficially tested implementation, is optional and needs to be enabled using
HTTPServerOption.enableHTTP2.