POC RSDK-10720 use TCP if colon in address #435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
changed the title
acmorrow
reviewed
May 16, 2025
| @@ -269,7 +269,11 @@ ModuleService::~ModuleService() { | |||
|
|
|||
| void ModuleService::serve() { | |||
| server_->register_service(impl_.get()); | |||
| const std::string address = "unix:" + module_->addr(); | |||
| std::string address; | |||
| if (module_->addr().find(':') == std::string::npos) { | |||
There was a problem hiding this comment.
I realize this is PoC and may not ever get merged, but this means of deciding that the intention is not to use AF_UNIX is potentially in conflict with fully solving RSDK-10642, because the presence of a : may be involved in helping a module determine whether it has been invoked in a way that is intended to be interpreted as a gRPC endpoint URI (e.g. dns:... or ipv4:... or unix:...), per https://grpc.github.io/grpc/cpp/md_doc_naming.html
There was a problem hiding this comment.
Yep! Totally agree, this was just to get something that works today available quickly. I will definitely clean this up if/when we want to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.