fix invalid setter

viamrobotics · Jul 17, 2024 · cc019fa · cc019fa
1 parent a835239
commit cc019fa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@viamrobotics/three",
-  "version": "0.0.9",
+  "version": "0.0.10",
   "license": "Apache-2.0",
   "type": "module",
   "files": [

diff --git a/src/orientation-vector.ts b/src/orientation-vector.ts
@@ -102,7 +102,7 @@ export class OrientationVector {
   }
 
   set z(value: number) {
-    this.#vec.setY(value);
+    this.#vec.setZ(value);
 
     if (this.autoNormalize) {
       this.#vec.normalize();
@@ -221,7 +221,7 @@ export class OrientationVector {
     return this.toArray();
   }
 
-  setFromQuaternion(quaternion: Quaternion, update = true): this {
+  setFromQuaternion(quaternion: Quaternion): this {
     // Get the transform of our +X and +Z points
     const conj = quatA.copy(quaternion).conjugate();
     const newX = quatB.multiplyQuaternions(quaternion, xAxis).multiply(conj);
@@ -280,9 +280,7 @@ export class OrientationVector {
 
     this.set(newZ.x, newZ.y, newZ.z, th);
 
-    if (update) {
-      this.#onChangeCallback?.();
-    }
+    this.#onChangeCallback?.();
 
     return this;
   }