Merge pull request #16 from viamrobotics/autoconvert

Autoconvert radians to degrees and vice versa when units are set
viamrobotics · Feb 29, 2024 · 4facad7 · 4facad7
2 parents db5b44e + cad138f
commit 4facad7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@viamrobotics/three",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "license": "Apache-2.0",
   "type": "module",
   "files": [

diff --git a/src/orientation-vector.ts b/src/orientation-vector.ts
@@ -131,6 +131,12 @@ export class OrientationVector {
   }
 
   setUnits(units: 'degrees' | 'radians'): this {
+    if (units === 'degrees' && this.#units === 'radians') {
+      this.#th = MathUtils.degToRad(this.#th);
+    } else if (units === 'radians' && this.#units === 'degrees') {
+      this.#th = MathUtils.radToDeg(this.#th);
+    }
+
     this.#units = units;
 
     return this;