Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-7475: Make enum consistent for training logs #618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jr22
Copy link
Member

@jr22 jr22 commented Jan 21, 2025

We have USAGE_COST_TYPE_TRAINING_LOGS_CLOUD_STORAGE and USAGE_COST_TYPE_ML_TRAINING_LOGS_EGRESS. they should be consistent and both either include or exclude ML

This enum is unused right now so its a "safe" breaking change

@jr22 jr22 marked this pull request as ready for review January 21, 2025 21:28
@github-actions github-actions bot added the safe to test committer is a member of this org label Jan 21, 2025
@jr22 jr22 requested a review from JosephBorodach January 21, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant