-
Notifications
You must be signed in to change notification settings - Fork 0
add e2e tests for go client tests #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| ) | ||
|
|
||
| func TestDrawLines(t *testing.T) { | ||
| offset := r3.Vector{X: 0, Y: 5000, Z: 0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved some of these objects so they are on screen for the snapshot
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
e2e/go-client.test.ts
Outdated
| }, | ||
| ]) | ||
| const page = await context.newPage() | ||
| await page.waitForTimeout(5000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wait for timeout? Any way to instead make this event driven (flakiness concern)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that is a copy paste leftover from the e2e with waiting for the robot configuration, I can remove for these ones
|
also removed nurbs e2e test because I just realized they are random so will be different each time |
Description
This PR adds e2e playwright tests for all of the test cases found in the go client. This approach will fail on breaking changes to presentation and also conveniently will throw errors if you break the actual go tests.
e.x.
Testing
Ran the e2e tests to generate the snapshot files