refactor: sdl3::events - Modernize/Update SDL3 Events #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, while using migrating from winit to SDL3, I noticed that some of the events strangely did not have all of the correct fields and names (In my particular case, I have multiple windows and many of the events were missing
window_id).Seeing as some of these events haven't been updates in years from their source, I went ahead and modernized the events a bit. Thankfully, as you can see in the examples, their replacement/updated usage is pretty easy to follow.
Key changes:
SDL_Event(where feasible).Eventso external code continues to referencecrate::event::Event.get_timestamp,get_window_id,is_*classifiers).