-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shuttle datum code cleanup #36651
Open
SECBATON-GRIFFON
wants to merge
18
commits into
vgstation-coders:Bleeding-Edge
Choose a base branch
from
SECBATON-GRIFFON:shuttle-creation-cleanup
base: Bleeding-Edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Shuttle datum code cleanup #36651
SECBATON-GRIFFON
wants to merge
18
commits into
vgstation-coders:Bleeding-Edge
from
SECBATON-GRIFFON:shuttle-creation-cleanup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug / Fix
This is either a bug or a fix for a bug.
Logging / Administration
This touches things involving admins or logging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[administration][bugfix]
What this does
makes this not rely on so many global vars init ing it from the start, makes it more vareditable
makes shuttle datums only get created if they have an associated control computer or docking port, to save on unnecessary ones being created in what was once said global vars
stops the admin log reporting errors for shuttles that shouldn't even be in the round like the bagel ferry on box, or vaults that haven't loaded in
How it was tested
obsing as ghost, sending mining shuttle back and forth, checking world log, calling vox raider midround ruleset and sending shuttle back and forth, spawning the broke ufo vault and activating the shuttle control console, calling blob ruleset and causing a shuttle lockdown, then destroying the blob to lift it
Changelog
馃啈