Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuttle datum code cleanup #36651

Open
wants to merge 18 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Jun 9, 2024

[administration][bugfix]

What this does

makes this not rely on so many global vars init ing it from the start, makes it more vareditable
makes shuttle datums only get created if they have an associated control computer or docking port, to save on unnecessary ones being created in what was once said global vars
stops the admin log reporting errors for shuttles that shouldn't even be in the round like the bagel ferry on box, or vaults that haven't loaded in

How it was tested

obsing as ghost, sending mining shuttle back and forth, checking world log, calling vox raider midround ruleset and sending shuttle back and forth, spawning the broke ufo vault and activating the shuttle control console, calling blob ruleset and causing a shuttle lockdown, then destroying the blob to lift it

Changelog

馃啈

  • bugfix: Shuttle datums now only get created if their docking ports or control computers actually exist, eliminating errors where non-existent shuttles complain about a lack of docking port in world logging.
  • bugfix; Security outpost shuttles now get consistently locked down when necessary along with mining and research ones.

@D3athrow-Issues D3athrow-Issues added Bug / Fix This is either a bug or a fix for a bug. Logging / Administration This touches things involving admins or logging. labels Jun 9, 2024
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review June 10, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix This is either a bug or a fix for a bug. Logging / Administration This touches things involving admins or logging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants