-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some subsystem init speedups #36632
Open
SECBATON-GRIFFON
wants to merge
17
commits into
vgstation-coders:Bleeding-Edge
Choose a base branch
from
SECBATON-GRIFFON:light-subsystem-speedup
base: Bleeding-Edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Some subsystem init speedups #36632
SECBATON-GRIFFON
wants to merge
17
commits into
vgstation-coders:Bleeding-Edge
from
SECBATON-GRIFFON:light-subsystem-speedup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the skip vaults config is the one that disables vaults from spawning then it might not have a real impact on live improvements. |
that's why i didn't factor it into the time i posted |
prepare for unforeseen consequences |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[performance]
What this does
rewrites the lighting subsystem to search by area first, skip ones without dynamic lighting, and then search the turfs in the area to apply it to, cutting down the time by half (0.5 seconds) while applying the same logic
moves mining suprises into the skip vaults thing if set in the config
addresses #36631 by cutting down object init by 1.2 seconds from that and 1.7 in total
2.2 seconds shaved overall
How it was tested
booting up tgstation.dmm
Changelog
🆑