Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some subsystem init speedups #36632

Open
wants to merge 17 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Jun 5, 2024

[performance]

What this does

rewrites the lighting subsystem to search by area first, skip ones without dynamic lighting, and then search the turfs in the area to apply it to, cutting down the time by half (0.5 seconds) while applying the same logic
moves mining suprises into the skip vaults thing if set in the config
addresses #36631 by cutting down object init by 1.2 seconds from that and 1.7 in total
2.2 seconds shaved overall

How it was tested

booting up tgstation.dmm

Changelog

🆑

  • tweak: Lighting and object subsystems are now notably faster, with about 2.2 seconds shaved off server initialization overall on boxstation as an example

@D3athrow-Issues D3athrow-Issues added the Performance Stealing my CPU cycles. label Jun 5, 2024
@Eneocho
Copy link
Collaborator

Eneocho commented Jun 5, 2024

kanef roams free with init speedup PRs while my homie adam is still held prisoner by the powers that be... we truly do live in a society...
we live in a soycity

@boy2mantwicethefam
Copy link
Contributor

If the skip vaults config is the one that disables vaults from spawning then it might not have a real impact on live improvements.

@SECBATON-GRIFFON
Copy link
Contributor Author

If the skip vaults config is the one that disables vaults from spawning then it might not have a real impact on live improvements.

that's why i didn't factor it into the time i posted

@SonixApache
Copy link
Contributor

prepare for unforeseen consequences

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review June 14, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Stealing my CPU cycles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants