Adjust pedalmarkins end

[rvilarl]

fixes #204

Changes the pedal markins brackets ends to include the area behind the note. Either to the next note in its voice or the end of the stave.

@mscuthbert is this a right approach?
@jaredjj3 does this fix the vexml issue?

Differences

current

reference

current

reference

current

reference

current

reference

current

reference

[mscuthbert]

Whatever the last note specified in the bracket should be included but it's hard to see how this interacts with the pedal up mark when both are used together.

[rvilarl]

Whatever the last note specified in the bracket should be included but it's hard to see how this interacts with the pedal up mark when both are used together.

Do you mean in the images above or in the code?
Are the images better now?

[jaredjj3]

@rvilarl, in the example in 0xfe/vexflow#1611, there are two voices. Would you make sure it works when there's another voice that causes additional area behind the last note the pedal is attached to?

[rvilarl]

@jaredjj3 tests with two voices added :)

[jaredjj3]

Wow, that looks so good! LGTM and I agree that would close my issue.

[rvilarl]

Whatever the last note specified in the bracket should be included but it's hard to see how this interacts with the pedal up mark when both are used together.

Do you mean in the images above or in the code? Are the images better now?

@mscuthbert what is the meaning of your statement? Should I comment the code?

[mscuthbert]

When there is a pedal release sign (looks like *) the pedal symbols should end before the note marked with *. Otherwise the symbol should go to the end of the note's "area" but in any case it is better to have the pedal mark extend to the end of some note rather than end with the notehead.

I don't know if Vexflow should be automatically eliding the common case of pedal up and immediately back down. See Gould for examples

[rvilarl]

@mscuthbert I have refactored the class to follow fix the alingment. Is that as expected?

[mscuthbert]

Yes, looks very good -- good enough to merge.

The two-voice(?) on one staff measures are currently non-sensical because of the incorrect stem-directions; I can't really judge how well the pedal marks are being rendered because my eyes can't figure out why 8 quarter notes are in one 4/4 measure.

[rvilarl]

@mscuthbert stems adjusted to avoid shift of notes

[rvilarl]

@mscuthbert is this now fine? look images above

[mscuthbert]

These look fantastic. I'd suggest clicking the Merge Button!