Bratseth/type inference cleanup #33179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnej27959
approved these changes
Jan 27, 2025
|
I need to move the testing to a level where entire statements are tested since the type resolution is at the statement level. I did that with for_each here but maybe I missed something. What tests did you have in mind? |
|
right, so ForEach now requires type resolving up-front, but it still tries to do it runtime also? Maybe we can simplify some of this later - the FieldValueConverter class is only used by ForEach. It looks like the tests you added should cover actual usage, so I think we can go ahead with this. |
|
Ok, thanks! Yes the simplification isn't complete with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.