-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve benchmark output from vespa-feed-client #33157
Merged
Merged
+301
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vekterli
previously approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
vespa-feed-client-api/src/main/java/ai/vespa/feed/client/OperationStats.java
Show resolved
Hide resolved
vespa-feed-client/src/test/java/ai/vespa/feed/client/impl/BenchmarkingClusterTest.java
Outdated
Show resolved
Hide resolved
bjorncs
force-pushed
the
bjorncs/feed-client-benchmark-stats
branch
from
January 27, 2025 13:09
8b028c7
to
0a5dadf
Compare
@vekterli PTAL. Last commit is new. |
vekterli
previously approved these changes
Jan 27, 2025
Move response counts into new shared structure if extended statistics is enabled. Fix ordering of fields, improve naming, render as integers.
Also add trailing new line to `BenchmarkingClusterTest`
bjorncs
force-pushed
the
bjorncs/feed-client-benchmark-stats
branch
from
January 28, 2025 09:45
375a78f
to
38794a7
Compare
Rebasing with master to (hopefully) resolve strange PR build failure |
vekterli
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extended output format is gated behind an environment variable.
Example: