Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve benchmark output from vespa-feed-client #33157

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

bjorncs
Copy link
Member

@bjorncs bjorncs commented Jan 22, 2025

The extended output format is gated behind an environment variable.

Example:

{
  "feeder.seconds": 730.403,
  "feeder.ok.count": 85858,
  "feeder.ok.rate": 117.549,
  "feeder.error.count": 0,
  "feeder.inflight.count": 277,
  "http.request.count": 3854073,
  "http.request.bytes": 8385743742,
  "http.request.MBps": 11.481,
  "http.exception.count": 0,
  "http.response.count": 3853796,
  "http.response.bytes": 505883404,
  "http.response.MBps": 0.693,
  "http.response.error.count": 3767938,
  "http.response.latency.millis.min": 0.000,
  "http.response.latency.millis.avg": 47.000,
  "http.response.latency.millis.max": 3826.000,
  "operation.latency": {
    "min": 361,
    "avg": 2211,
    "max": 24990
  },
  "http.response": {
    "200": {
      "count": 85858,
      "latency": {
        "min": 197,
        "avg": 1729,
        "max": 3826
      }
    },
    "429": {
      "count": 3767938,
      "latency": {
        "min": 0,
        "avg": 9,
        "max": 461
      }
    }
  }
}

@bjorncs bjorncs requested a review from vekterli January 22, 2025 16:18
vekterli
vekterli previously approved these changes Jan 23, 2025
Copy link
Member

@vekterli vekterli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjorncs bjorncs force-pushed the bjorncs/feed-client-benchmark-stats branch from 8b028c7 to 0a5dadf Compare January 27, 2025 13:09
@bjorncs
Copy link
Member Author

bjorncs commented Jan 27, 2025

@vekterli PTAL. Last commit is new.

vekterli
vekterli previously approved these changes Jan 27, 2025
@bjorncs bjorncs force-pushed the bjorncs/feed-client-benchmark-stats branch from 375a78f to 38794a7 Compare January 28, 2025 09:45
@bjorncs
Copy link
Member Author

bjorncs commented Jan 28, 2025

Rebasing with master to (hopefully) resolve strange PR build failure

@bjorncs bjorncs merged commit 15df52d into master Jan 28, 2025
3 checks passed
@bjorncs bjorncs deleted the bjorncs/feed-client-benchmark-stats branch January 28, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants