fix(CI): use the correct version for VespaCLI publishing #32233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esolitos
force-pushed
the
esolitos-patch-1
branch
from
43563b4 to
c40dcc4
Compare
esolitos
force-pushed
the
esolitos-patch-1
branch
from
6b39935 to
e6b4991
Compare
mpolden
reviewed
Aug 23, 2024
mpolden
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
VERSIONevnronment variable is set from the prepare jobWhy
Additional Info
Why do we need a token for a public API endpoint?
My initial assumption was the lack of User-Agent, but a quick test against httpbin.io showed that this was not the case.
As I could not reproduce it, my next assumption is that we might be hitting a Rate Limit, which can return a 429 as well as a 403. This limit is pretty low (60 req/hour) and ties to the IP address, which for GH Shared Runners is shared amongst many runners, so hitting this limit is likely quite easy.
By using the token we get access to a much higher rate limit.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.