Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add transfer Leader cmd #5963

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

E2ern1ty
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

I think this feature will be more universal if placed in the nebula kernel
vesoft-inc/nebula-operator#270

How do you solve it?

add new transfer cmd for nebula, remove leader before change storaged group.
Maybe this function needs some guidance to make it better.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

test in 3 replica,2 shards,just as the picture:
企业微信截图_31c1c9b2-9f8c-4454-aed5-87cbc76ade5e

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@E2ern1ty E2ern1ty requested review from dutor, codesigner and a team as code owners October 23, 2024 03:23
@critical27
Copy link
Contributor

critical27 commented Dec 18, 2024

Thx for contribution. But I'm wondering what's the purpose of this command? Is it used for data balance remove ..., as described in vesoft-inc/nebula-operator#270? If yes, what happened here is that before we remove a part from the leader, the leadership has already been transferred. So the command is not quite necessary.

@E2ern1ty
Copy link
Contributor Author

E2ern1ty commented Dec 19, 2024

Thx for contribution. But I'm wondering what's the purpose of this command? Is it used for data balance remove ..., as described in vesoft-inc/nebula-operator#270? If yes, what happened here is that before we remove a part from the leader, the leadership has already been transferred. So the command is not quite necessary.

This command is used to migrate the leaders on a storage node before repairing the machine. It does not involve any data migration, aiming to minimize the impact on upper-layer services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants