Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ifa->ifa_addr nullptr #5863

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix ifa->ifa_addr nullptr #5863

wants to merge 7 commits into from

Conversation

qingyan01
Copy link

@qingyan01 qingyan01 commented Apr 18, 2024 •
edited
Loading

What type of PR is this?

bug

What problem(s) does this PR solve?

image

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@QingZ11 QingZ11 added the ready-for-testing PR: ready for the CI test label Apr 18, 2024
@QingZ11 QingZ11 requested a review from dutor April 18, 2024 10:17
@yixinglu yixinglu changed the title fix ifa->ifa_addr 空指针 fix ifa->ifa_addr nullptr Apr 19, 2024
dutor
dutor previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the fix.

@dutor dutor enabled auto-merge (squash) April 19, 2024 09:34
@qingyan01 qingyan01 requested a review from yixinglu May 7, 2024 03:39
auto-merge was automatically disabled May 7, 2024 03:43

Head branch was pushed to by a user without write access

yixinglu
yixinglu previously approved these changes May 7, 2024
View reviewed changes
@yixinglu yixinglu enabled auto-merge (squash) May 7, 2024 10:46
@yixinglu yixinglu requested review from dutor and Salieri-004 May 7, 2024 10:46
Salieri-004
Salieri-004 previously approved these changes May 7, 2024
View reviewed changes
@qingyan01
Update NetworkUtils.cpp
8bb11b5 
fix sa_family not exist
auto-merge was automatically disabled May 31, 2024 02:51

Head branch was pushed to by a user without write access

@qingyan01 qingyan01 dismissed stale reviews from Salieri-004 and yixinglu via 8bb11b5 May 31, 2024 02:51
@qingyan01 qingyan01 requested review from Salieri-004 and yixinglu May 31, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salieri-004 Salieri-004 Salieri-004 approved these changes

@dutor dutor Awaiting requested review from dutor

@yixinglu yixinglu Awaiting requested review from yixinglu

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qingyan01 @dutor @yixinglu @Salieri-004 @QingZ11