-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add white outlines to the logos to look nicer on dark mode #1351
base: main
Are you sure you want to change the base?
Conversation
This helps it look nicer on dark-mode, and should not impact light-mode situations (other than taking up a little padding space around it)
Thank you for looking into this. Let me look into alternatives to accomplishing readability in dark mode. I find the white outline quite jarring as proposed in this PR. |
would it look better if the borders were thinner? |
I pushed a commit that made the title legible in dark mode (that was certainly a necessary improvement, thank you for noticing the issue). I don't think we should add outlines to the primary svgs that we distribute from the "logos" page (they'd for example interfere if someone used them on slides with a light but not white background). I personally don't mind much that the logo is a bit muted in dark mode, but we could consider variations of the logo colors itself that would work better on a dark background. @jaybosamiya-ms is the fix on main sufficient for now? |
Regarding the GitHub org logo, a white background should work, I'll give it a shot! Can I close this for now? |
Sure, feel free to close; the main issue is fixed at this point. I'm not closing it right now, as a reminder of the GH org logo test, but once you're done with that, feel free to close this. |
This PR updates the Verus logos to have white borders to perform this change (screenshots taken in dark mode):
Details
I wrote the following filter to wrap around the outermost group of the SVGs for the logos; it essentially merely adds a 2.5 width white-colored dilation around any object where the filter is applied. The width/height of the images needed to be updated to account for this (from 106 -> 106+2x2.5 == 111), but otherwise, no other changes were necessary.
Also, I've regenerated the PNGs (via
inkscape -w 333 -h 333 verus-color.svg -o verus-color.png
, ...; followed byoptipng -o7
to squeeze PNG sizes down).