Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.82.0 #1330

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Rust 1.82.0 #1330

wants to merge 5 commits into from

Conversation

utaal
Copy link
Collaborator

@utaal utaal commented Oct 31, 2024 •
edited
Loading

This is based on @ziqiaozhou's PR #1325 rebased after rustc-1.72.0 was merged.

@ziqiaozhou:

This draft PR is only created as a draft and is not intended to be merged to v1.79.

@utaal, this is the change I mentioned about supporting v1.82. The only issue I encountered is about negative trait and conflicted trait implementations.

conflicting implementations of trait `T57_IntoIterator` for type `&mut std::boxed::Box<[_], _>`

Or

found both positive and negative implementation of trait `T55_Iterator` for type `&mut std::boxed::Box<[_], _>`.

The way I bypass it for now is to check the polarity and add negative when needed. But still, I need to explicitly rule out Box cases.

Adding with_negative_coherence feature finally solved the issue I encountered. But I have 5 failed tests in example which is expected to fail and does fail. I may need to check the test lib and see why the failure is not recognized as a correct failure.

@ziqiaozhou @utaal
Add allow(non_snake_case) to __VERUS_CONST_BODY__
d6ed837
@ziqiaozhou @utaal
fix new interface
65d7920 
tmp fix: conflict conflicting implementations of trait IntoIteratr in Box

wip: fix typo

wip: repalce preds_on
@ziqiaozhou @utaal
Skip non-local trait impl for Iterator & IntoIterator
a091f2b 
This is to fix
error: conflicting implementations of trait `T57_IntoIterator` for type `&mut std::boxed::Box<[_], _>`
/.rustup/toolchains/1.82.0-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:351:1
     |
/.rustup/toolchains/1.82.0-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2329:1

error: conflicting implementations of trait `T55_Iterator` for type `std::boxed::Box<[_], _>`

note: This error was found in Verus pass: ownership checking of tracked code
@ziqiaozhou @utaal
Only skip trait impl for Box && Adding negative trait in lifetime che…
234ec43 
…cking if it is negative trait
@ziqiaozhou @utaal
Do not skip Box by adding with_negative_coherence
c224982
@utaal utaal changed the title Rustc 1.82.0 Rust 1.82.0 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utaal @ziqiaozhou