Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: inet:service:tenant / inet:service:subscription and lots of interface inheritance #3995

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

invisig0th
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (20e17ba) to head (0926b0b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3995      +/-   ##
==========================================
- Coverage   96.44%   96.37%   -0.07%     
==========================================
  Files         253      253              
  Lines       59328    59333       +5     
==========================================
- Hits        57219    57183      -36     
- Misses       2109     2150      +41     
Flag Coverage Δ
linux 96.37% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@invisig0th invisig0th changed the title inet:service:tenant / inet:service:subscription and lots of interface inheritance WIP: inet:service:tenant / inet:service:subscription and lots of interface inheritance Nov 8, 2024
Copy link
Contributor

@therealsilence therealsilence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments, one typo

synapse/models/crypto.py Show resolved Hide resolved
synapse/models/economic.py Show resolved Hide resolved
synapse/models/inet.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants