flatbuffer builder reuse

[Lynnworld]

use flatbuffer Builder Clear() , so it can reuse it's inner buf .

void | Clear () // Reset all the state in this FlatBufferBuilder so it can be reused to construct another buffer.

https://flatbuffers.dev/classflatbuffers_1_1_flat_buffer_builder.html#ae94b94ba71ea0aeb2d9a98c43b713412

[ibc]

Thanks a lot. Just a cosmetic request.

[jmillan]

Currently we use Reset() which calls Clear() plus deallocates the buffer. So indeed yes, calling Clear() is just enough and does not require to reallocate the buffer on the next call.

But this PR should only replace Reset() by Clear(). It's not necessary to move the builder from being an instance member to a thread local variable.

[Lynnworld]

current Channel socket will new ChannelRequest every time , so try to reuse request instead of thread_local builder ?

[jmillan]

current Channel socket will new ChannelRequest every time , so try to reuse request instead of thread_local builder ?

Correct, that's orthogonal to Reset() replacement described in the PR description, but it's true, we can reuse the FlatBufferBuilder for every request since all responses are synchronous at the moment.

[jmillan]

Please run the linter npm run lint:worker

[ibc]

Thanks, merging.

[Lynnworld]

oops, I'll make a new PR later for ChannelRequest and ChannelNotification reuse , and remove threal_local static . @jmillan @ibc