-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust: flatbuffers PlainTransport #1135
Conversation
CI failing but LGTM |
@@ -103,7 +103,7 @@ union Body { | |||
FBS.Transport.CloseConsumerRequest, | |||
FBS.Transport.CloseDataProducerRequest, | |||
FBS.Transport.CloseDataConsumerRequest, | |||
FBS.PlainTransport.ConnectRequest, | |||
PlainTransport_ConnectRequest: FBS.PlainTransport.ConnectRequest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create this alias for every element in the enum in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things like Clippy suggestions should ideally be squashed with commits where these complaints originate (same for TS) rather than as a separate commits before opening PR, makes it easier to review.
Also there are a lot of things remaining to be done, some of which are in your or my head and some in PR comments. They should all ideally be TODO comments right in the code, such that anyone can come later and do refactoring/cleanup and resolve those TODOs.
Multiple comments as a review, please 🙏 Too many notifications. |
I'll squash all commits of this branch into a single one for clarity and force push, ok? |
I don't think I have a strong preference, but maybe do that once you're done with changes, so I can review the diff rather than re-review everything again? |
644fc5a
to
37d5467
Compare
Yep, all concerns have been handled. |
37d5467
to
ac8b277
Compare
ac8b277
to
e469b4e
Compare
Hm... so you have force pushed a few times anyway 😕 |
I know I know.., I have my hands out of the keyword.., promise 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't re-read the whole thing again, but looks fine
The following two points I'll handle in a different PR once this is merged.