Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: flatbuffers PlainTransport #1135

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Rust: flatbuffers PlainTransport #1135

merged 1 commit into from
Aug 30, 2023

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Aug 3, 2023

The following two points I'll handle in a different PR once this is merged.

  • Use Protocol type rather than convert from/to string.
  • Create a SrtpCrytoSuite type in flatbuffers to avoid converting from/to string.

@jmillan jmillan requested review from nazar-pc and ibc August 3, 2023 15:48
rust/src/router/plain_transport.rs Outdated Show resolved Hide resolved
rust/src/router/plain_transport.rs Show resolved Hide resolved
rust/src/srtp_parameters.rs Show resolved Hide resolved
rust/src/srtp_parameters.rs Show resolved Hide resolved
@ibc
Copy link
Member

ibc commented Aug 4, 2023

CI failing but LGTM

@@ -103,7 +103,7 @@ union Body {
FBS.Transport.CloseConsumerRequest,
FBS.Transport.CloseDataProducerRequest,
FBS.Transport.CloseDataConsumerRequest,
FBS.PlainTransport.ConnectRequest,
PlainTransport_ConnectRequest: FBS.PlainTransport.ConnectRequest,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create this alias for every element in the enum in another PR.

Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things like Clippy suggestions should ideally be squashed with commits where these complaints originate (same for TS) rather than as a separate commits before opening PR, makes it easier to review.

Also there are a lot of things remaining to be done, some of which are in your or my head and some in PR comments. They should all ideally be TODO comments right in the code, such that anyone can come later and do refactoring/cleanup and resolve those TODOs.

rust/src/router/plain_transport.rs Outdated Show resolved Hide resolved
rust/src/router/plain_transport.rs Show resolved Hide resolved
rust/src/srtp_parameters.rs Outdated Show resolved Hide resolved
rust/src/srtp_parameters.rs Show resolved Hide resolved
rust/tests/integration/plain_transport.rs Outdated Show resolved Hide resolved
rust/src/router/plain_transport.rs Outdated Show resolved Hide resolved
rust/src/router/plain_transport.rs Outdated Show resolved Hide resolved
@nazar-pc
Copy link
Collaborator

Multiple comments as a review, please 🙏 Too many notifications.

@jmillan
Copy link
Member Author

jmillan commented Aug 30, 2023

Multiple comments as a review, please 🙏 Too many notifications.

I'll squash all commits of this branch into a single one for clarity and force push, ok?

@nazar-pc
Copy link
Collaborator

I don't think I have a strong preference, but maybe do that once you're done with changes, so I can review the diff rather than re-review everything again?

@jmillan jmillan force-pushed the fbs-plaintransport branch from 644fc5a to 37d5467 Compare August 30, 2023 14:50
@jmillan jmillan requested a review from nazar-pc August 30, 2023 14:50
@jmillan
Copy link
Member Author

jmillan commented Aug 30, 2023

but maybe do that once you're done with changes, so I can review the diff rather than re-review everything again?

Yep, all concerns have been handled.

@jmillan jmillan force-pushed the fbs-plaintransport branch from 37d5467 to ac8b277 Compare August 30, 2023 15:07
@jmillan jmillan force-pushed the fbs-plaintransport branch from ac8b277 to e469b4e Compare August 30, 2023 15:11
@nazar-pc
Copy link
Collaborator

Hm... so you have force pushed a few times anyway 😕

@jmillan
Copy link
Member Author

jmillan commented Aug 30, 2023

Hm... so you have force pushed a few times anyway 😕

I know I know.., I have my hands out of the keyword.., promise 🙏

Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't re-read the whole thing again, but looks fine

@jmillan jmillan merged commit 2dc44f9 into flatbuffers Aug 30, 2023
22 of 30 checks passed
@jmillan jmillan deleted the fbs-plaintransport branch August 30, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants