Allow setting RtpEncodingParameters for individual encodings #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
reviewed
Jul 14, 2021
| parameters.encodings[idx] = { ...encoding, ...params }; | ||
| }); | ||
| parameters.encodings.forEach((encoding: RTCRtpEncodingParameters, idx: number) => | ||
| { |
There was a problem hiding this comment.
This is wrong. Old matching properties override the new ones.
There was a problem hiding this comment.
This is the way property assignment was done before. It seems to be correct:
const oldObj = { x: 1 }
const newObj = { x: 2 }
{ ...oldObj, ...newObj } // { x: 2 }It transpiles to:
parameters.encodings[idx] = Object.assign(Object.assign({}, encoding), params[idx]);Which also seems right.
There was a problem hiding this comment.
I'm in mobile and could be wrong. I'll review in next days. Thanks
|
I want to re-review this, sorry for the delay, off for many weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Producer::setRtpEncodingParametersto also accept an array of RTCRtpEncodingParameters, for setting different parameters for each encoding. Passing a single RTCRtpEncodingParameters object will work as before.Usecases
I have a few uses for this - just some examples:
setMaxSpatialLayerbut reversed).scaleResolutionDownBydepending on the current source resolution of the track.