Revert changes since ICE fields cannot be in DtlsParameters (obviously)

versatica · Feb 16, 2024 · df9b5a5 · df9b5a5
1 parent 022a1b1
commit df9b5a5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 23 deletions.
diff --git a/src/Transport.ts b/src/Transport.ts
@@ -100,14 +100,6 @@ export type DtlsParameters = {
 	 * Server DTLS fingerprints.
 	 */
 	fingerprints: DtlsFingerprint[];
-	/**
-	 * ICE ufrag.
-	 */
-	iceUfrag?: string;
-	/**
-	 * ICE password.
-	 */
-	icePwd?: string;
 };
 
 /**

diff --git a/src/handlers/sdp/commonUtils.ts b/src/handlers/sdp/commonUtils.ts
@@ -151,16 +151,16 @@ export function extractDtlsParameters({
 }): DtlsParameters {
 	let setup = sdpObject.setup;
 	let fingerprint = sdpObject.fingerprint;
-	let iceUfrag = sdpObject.iceUfrag;
-	let icePwd = sdpObject.icePwd;
 
-	const mediaObject = (sdpObject.media || []).find(
-		(m: { port: number }) => m.port !== 0
-	);
+	if (!setup || !fingerprint) {
+		const mediaObject = (sdpObject.media || []).find(
+			(m: { port: number }) => m.port !== 0
+		);
 
-	if ((!setup || !fingerprint) && mediaObject) {
-		setup ??= mediaObject.setup;
-		fingerprint ??= mediaObject.fingerprint;
+		if (mediaObject) {
+			setup ??= mediaObject.setup;
+			fingerprint ??= mediaObject.fingerprint;
+		}
 	}
 
 	if (!setup) {
@@ -169,11 +169,6 @@ export function extractDtlsParameters({
 		throw new Error('no a=fingerprint found at SDP session or media level');
 	}
 
-	if ((!iceUfrag || !icePwd) && mediaObject) {
-		iceUfrag ??= mediaObject.iceUfrag;
-		icePwd ??= mediaObject.icePwd;
-	}
-
 	let role: DtlsRole | undefined;
 
 	switch (setup) {
@@ -204,8 +199,6 @@ export function extractDtlsParameters({
 				value: fingerprint.hash,
 			},
 		],
-		iceUfrag,
-		icePwd,
 	};
 
 	return dtlsParameters;