Use a single and bidirectional socket to communicate with the worker (fix Python3 <= 3.10 requirement) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Rationale - In mediasoup server we used to use also a single bidirectional socket at the beginning, but there was a bug in Node for Windows so we ended spliting it into two (one for sending and one for receiving). - Anyway, **mediasoup-client-aiortc** doesn't support Windowes. - And probably, such a bug in Node for Windows is already fixed (I don't care).
jmillan
approved these changes
Sep 15, 2023
|
For whatever reason tests in CI in macOS machines never end... |
ibc
changed the title
ibc
deleted the
use-a-single-bidirectional-socket-to-communicate-with-worker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Awesome side effect