Modernize

[ibc]

Make it be similar to mediasoup-client repo.

• Update NPM deps.
• Update TypeScript.
• Update ESLint.
• Remove lib from the repo.
• Remove src and temp files/folders in worker from the NPM package.
• Move test to TypeScript.
• Add CI.

Breaking Changes

• PYTHON3 env is now PYTHON.
• PYP3 env (note that it was a typo anyway) is now PIP.

Notes

• Some issues were found while doing this work. Both are reported in separate issues and workaround have been done in this branch to not block this PR:
  • TypeScript error in FakeRTCDataChannel #24
  • Error in Python link mypy: "object" has no attribute "close" #25
• CI fails only in macOS. Probably because there Python 3.11 is used, so issue Error with Python >= 3.11 #22 happens. This is: we must ensure that the CI machine runs Python 3.10. However this can be addressed in Error with Python >= 3.11 #22 instead, so not a blocker.

[ggoldens]

LGTM. Is there any reason for keep passing loop in channel.py since now it's not used anymore?

[ibc]

LGTM. Is there any reason for keep passing loop in channel.py since now it's not used anymore?

No, and in fact I forgot to remove it. I'll do tomorrow.

[jmillan]

is this to make linter happy?

[ibc]

Yes. Let me explain:

npm run lint:python

which runs:

executeCmd(`cd worker && ${PYTHON} -m flake8 && cd ..`);
executeCmd(`cd worker && ${PYTHON} -m mypy . && cd ..`);

Indeed we don't use RTCDataChannel in hander.py so flake8 complains due to "unused var". However we cannot remove it since this:

# dictionary of dataChannelds mapped by internal id
self._dataChannels = dict()  # type: Dict[str, RTCDataChannel]

Believe me or not, but such a # type: Dict[str, RTCDataChannel] comment is checked by mypy and it needs to know what RTCDataChannel is. So here two conflicting linters / type checkers / whatever. So we must make both happy.

Then you may thing "why not this instead of importing twice from aiortc?":

from aiortc import (
    RTCConfiguration,
    RTCPeerConnection,
    RTCRtpTransceiver,
    RTCSessionDescription,
    RTCStatsReport,
    RTCDataChannel  # noqa: F401
)

or this:

from aiortc import (
    RTCConfiguration,
    RTCPeerConnection,
    RTCRtpTransceiver,
    RTCSessionDescription,
    RTCStatsReport,
    # noqa: F401
    RTCDataChannel
)

or this:

# noqa: F401
from aiortc import (
    RTCConfiguration,
    RTCPeerConnection,
    RTCRtpTransceiver,
    RTCSessionDescription,
    RTCStatsReport,
    RTCDataChannel
)

Well, because none of those work. I've tried everything. Python ecosystem sucks a lot.

[ibc]

LGTM. Is there any reason for keep passing loop in channel.py since now it's not used anymore?

Done.